Migrate multiple queued withdrawals #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticWalrus
approved these changes
Oct 6, 2023
ypatil12
merged commit 68c5971
into
Combined-Withdrawal-Flow-No-Limbo
6 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the migrateQueuedWithdrawal function within the DM to migrate multiple queued withdrawals to easily batch multiple migrations. To handle updating multiple withdrawals without reverting, the
migrateQueuedWithdrawalin the SM does not revert if the withdrawal has already been provided. We also remove all withdrawalRoot calculations from the DM.Migration tests will be added in subsequent PR.